Fix bug with ica.plot_properties#13885
Open
larsoner wants to merge 13 commits intomne-tools:mainfrom
Open
Conversation
* upstream/main: MAINT: Update for vtk deprecation (mne-tools#13886) ENH: Allow passing source detector distances to beer lambert law (mne-tools#13875)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A start toward #13879. But there are some oddities in the code... I think some parts should be plotting the variance of the dropped epochs, but silently don't currently. Now they explicitly plot zero, which is not ideal (I guess it could mean "unknown"?). The indexing logic was also broken (off-by-one error).
I suspect these plots have been wrong for some time in hard-to-detect ways. Will need to look further...
Closes #13879