fix: strict attach does not replay log for dead sessions#26

Open

rmorgans wants to merge 28 commits into

mobydeck:mainfrom

rmorgans:fix/strict-attach-no-replay

Commits on Mar 14, 2026

fix: close leaked fds in openpty fallback, add static assertions

rmorgans
and
claude
committed
fix: defensive checks for cwd restore, malloc, and log writes

rmorgans
and
claude
committed
fix: retry partial writes in packet and push paths

rmorgans
and
claude
committed
fix: use write_all in send_kill (missed in initial fix)

rmorgans
and
claude
committed
fix: treat write()=0 as failure, add regression tests

rmorgans
and
claude
committed
fix: reject SCROLLBACK_SIZE == 0 in static assertion

rmorgans
and
claude
committed
fix: guard all log operations behind log_fd >= 0

rmorgans
and
claude
committed

Commits on Mar 15, 2026

fix: make signal handlers async-signal-safe and handle blocked writes

rmorgans
and
claude
committed
test: add forkpty-based signal safety integration tests

rmorgans
and
claude
committed
chore: ignore *.dSYM directories in .gitignore

rmorgans
and
claude
committed
fix(master): use umask(0177) in create_socket to prevent S_IXUSR race

authored and
rmorgans
committed
fix(attach): send MSG_DETACH before exit on detach_char press

authored and
rmorgans
committed
fix(attach): cap session log replay to last 128KB

authored and
rmorgans
committed
fix(attach): replace ATCH_SESSION-only self-attach guard with PID ancestry check

authored and
rmorgans
committed
Fix log file growing to 2x configured cap

ricardovfreixo
authored and
rmorgans
committed
docs: add fork constitution

authored and
rmorgans
committed
docs(man): add atch.1 man page (section 1)

authored and
rmorgans
committed
build(makefile): add install target and PREFIX variable

authored and
rmorgans
committed
Merge fix/write-all (#22): retry partial writes in packet and push paths
rmorgans
committed
Merge fix/signal-safety (#25): async-signal-safe handlers and blocked-write fix
rmorgans
committed
Merge fix/defensive-checks (#23): guard cwd restore, malloc, and log writes
rmorgans
committed
Merge fix/openpty-and-asserts (#24): close leaked fds, add static assertions
rmorgans
committed
test: add fd leak regression test for openpty fallback

rmorgans
and
claude
committed
test: add cwd preservation regression test for socket_with_chdir

rmorgans
and
claude
committed
Update fix/defensive-checks: add cwd preservation regression test
rmorgans
committed
Update fix/openpty-and-asserts: add fd leak regression test
rmorgans
committed
fix: strict attach does not replay log for dead sessions

rmorgans
and
claude
committed
test: add regression test for strict attach log replay

rmorgans
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: strict attach does not replay log for dead sessions#26

fix: strict attach does not replay log for dead sessions#26
rmorgans wants to merge 28 commits into
mobydeck:mainfrom
rmorgans:fix/strict-attach-no-replay

Commits on Mar 14, 2026

fix: close leaked fds in openpty fallback, add static assertions

fix: defensive checks for cwd restore, malloc, and log writes

fix: retry partial writes in packet and push paths

fix: use write_all in send_kill (missed in initial fix)

fix: treat write()=0 as failure, add regression tests

fix: reject SCROLLBACK_SIZE == 0 in static assertion

fix: guard all log operations behind log_fd >= 0

Commits on Mar 15, 2026

fix: make signal handlers async-signal-safe and handle blocked writes

test: add forkpty-based signal safety integration tests

chore: ignore *.dSYM directories in .gitignore

fix(master): use umask(0177) in create_socket to prevent S_IXUSR race

fix(attach): send MSG_DETACH before exit on detach_char press

fix(attach): cap session log replay to last 128KB

fix(attach): replace ATCH_SESSION-only self-attach guard with PID ancestry check

Fix log file growing to 2x configured cap

docs: add fork constitution

docs(man): add atch.1 man page (section 1)

build(makefile): add install target and PREFIX variable

Merge fix/write-all (#22): retry partial writes in packet and push paths

Merge fix/signal-safety (#25): async-signal-safe handlers and blocked-write fix

Merge fix/defensive-checks (#23): guard cwd restore, malloc, and log writes

Merge fix/openpty-and-asserts (#24): close leaked fds, add static assertions

test: add fd leak regression test for openpty fallback

test: add cwd preservation regression test for socket_with_chdir

Update fix/defensive-checks: add cwd preservation regression test

Update fix/openpty-and-asserts: add fd leak regression test

fix: strict attach does not replay log for dead sessions

test: add regression test for strict attach log replay