[SHIPKIT-513] Automated commit message should have CI build ID#682
[SHIPKIT-513] Automated commit message should have CI build ID#682ArturSkowronski wants to merge 7 commits intomasterfrom
Conversation
|
@mockitoguy Some problem with testDownstream:testMockitoMockito stage. I'll reopen after I'll resolve them |
|
@mockito/shipkit-developers seems to be connected to #680 |
mockitoguy
left a comment
mockitoguy
left a comment
There was a problem hiding this comment.
I don't think this works quite yet, please check out my feedback.
| t.setCommitMessage(System.getenv("TRAVIS_COMMIT_MESSAGE")); | ||
| t.setPullRequest(isPullRequest); | ||
| } | ||
| project.getTasks().withType(ReleaseNeededTask.class, t -> { |
There was a problem hiding this comment.
We want to set the commit message on the GitCommitTask. We don't want to generate commit message for ReleaseNeededTask because this task should work on verbatim commit message supplied by Travis. ReleaseNeededTask is not making commits :)
Check out the initial design of this feature at #514
When you work on this feature, I suggest to test it this way:
./gradlew performRelease -PdryRun
Above will get you a local commit with the message. Please ensure that this commit has the stuff we need.
Thank you for working on this!!!
There was a problem hiding this comment.
Sure, I created PR to confirm my assumptions were right (which were wrong, but now I got feedback :)).
I'll add necessary changes.
ArturSkowronski
force-pushed
the
SHIPKIT-513
branch
from
e87ff42 to
0abad20
Compare
2 participants
Solving issue #513