fix: notify session when SSE stream closes without event ID #1940
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1811
When an SSE stream closes without having received any events with IDs, the client silently returns without notifying the session layer. This leaves
call_tool()hanging indefinitely.Changes
elsebranch in_handle_sse_responseto handle the case wherelast_event_id is NoneJSONRPCErrorwithCONNECTION_CLOSEDcode back to the sessioncall_tool()properly raisesMcpErrorinstead of hangingRoot Cause
The issue occurs when:
_handle_sse_responsefunction exits silently (nolast_event_idto reconnect with)Validation
uv run pyrightpasses with 0 errorsCloses #1811