Empty inputSchema requires the type key#100
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Jul 31, 2025
Merged
Conversation
b4b715f to
8c4f0ae
Compare
koic
reviewed
Jul 31, 2025
Member
|
The linter appears to be failing in CI. It can be checked locally by running |
Member
|
CI passed. Can you squash your commits into one? |
When defining a tool without any arguments taken, it should be allowed
to not have to define the `input_schema` at all, and the default value
for such a scenario should be `{ type: "object" }` as per the schema.
https://github.com/modelcontextprotocol/modelcontextprotocol/blob/16d91abb68bbc824944c5bda4ac2e2ccaaa74b0f/schema/2025-06-18/schema.ts#L896-L900
0812ac7 to
2508def
Compare
Contributor
Author
|
@koic Done! |
koic
approved these changes
Jul 31, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When defining a tool without any arguments taken, it should be allowed to not have to define the
input_schemaat all, and the default value for such a scenario should be{ type: "object" }as per the schema.https://github.com/modelcontextprotocol/modelcontextprotocol/blob/16d91abb68bbc824944c5bda4ac2e2ccaaa74b0f/schema/2025-06-18/schema.ts#L896-L900
Motivation and Context
When testing a tool without the
input_schemadefined, themcp-inspectorreturns an error when trying to list the tool:How Has This Been Tested?
Added new tests and locally using the
mcp-inspector.Breaking Changes
Types of changes
Checklist
Additional context