fix(deps): disable chrono default features to drop iana-time-zone pull-in#835
Closed
SarthakB11 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix(deps): disable chrono default features to drop iana-time-zone pull-in#835SarthakB11 wants to merge 1 commit intomodelcontextprotocol:mainfrom
SarthakB11 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Author
|
Closing in favor of #829 by @chitao1234 (opened 2026-05-01, same fix, simpler diff). I missed it in pre-flight, apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
rmcp's non-wasm chrono dependency is currently declared withoutdefault-features = false, so chrono's defaultclockfeature is enabled.clockbrings iniana-time-zone, which on Haiku pullsiana-time-zone-haikuand linkslibbe.so.libbe.soitself depends on systemlibzstd.so.1, which conflicts with the hidden symbols in vendoredzstd-sysand breaks the final link for downstreams that combinermcpwithzstdon Haiku (see #828 and gyscos/zstd-rs#363).rmcp only uses
chrono::DateTime<Utc>,chrono::Utc::now(),chrono::Duration, and RFC3339 formatting (no local timezone discovery), so theclock/iana-time-zonepull-in is unnecessary.This switches the non-wasm chrono dep to
default-features = falsewithserdeandnowenabled.nowprovidesUtc::now()withoutiana-time-zone. The wasm target block already haddefault-features = falseand is left unchanged.Closes #828.
How Has This Been Tested?
No behavioral changes; chrono usage in rmcp is limited to
Utc::now,DateTime<Utc>,Duration, RFC3339 formatting, and serde derives, all retained via thenowandserdefeatures. CI matrix will exercise the full surface.Breaking Changes
None. Public API and runtime behavior are unchanged. Default features dropped (
oldtime,wasmbind,clock) are not used by rmcp on the non-wasm target.Types of changes
Checklist