fetch - max_length customization#1774
Closed
jritsema wants to merge 2 commits intomodelcontextprotocol:mainfrom
Closed
fetch - max_length customization#1774jritsema wants to merge 2 commits intomodelcontextprotocol:mainfrom
jritsema wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
- Updated server implementation to utilize `MAX_LENGTH` environment variable - Improved README.md with detailed customization instructions for `max_length`
Member
|
@claude would you recommend merging this pull request? |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Author
|
would you consider merging? |
Member
|
Thanks for the PR, and apologies for the long delay reviewing it. I think we want to reduce the number of possible configuration options for servers to reduce complexity, especially where there are alternative approaches to solving the same problem (e.g. setting your agent's system prompt to always set a particular max_length). If this hard blocks some workflows, I'd be open to hearing more and reconsidering this. In the mean time you can workaround by running a fork locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the
fetchMCP server, allows overriding of the defaultmax_lengthargument using aMAX_LENGTHenvironment variable.Server Details
Motivation and Context
The default max_length of 5000 is sometimes too low and requires too many HTTP requests. It would be nice to be able to increase this value on a case by case basis.
How Has This Been Tested?
I tested this change with Amazon Q CLI.
Breaking Changes
No.
Types of changes
Checklist
Additional context