Add All In One Advertising MCP Server#2817
Closed
stephenbessey wants to merge 2 commits intomodelcontextprotocol:mainfrom
Closed
Add All In One Advertising MCP Server#2817stephenbessey wants to merge 2 commits intomodelcontextprotocol:mainfrom
stephenbessey wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
brandon-uplevel
left a comment
brandon-uplevel
left a comment
There was a problem hiding this comment.
Automated test review - Overall the server implementation looks good. Added a few suggestions for improvement around input validation and error handling.
| async def call_tool(self, name: str, arguments: dict) -> list[TextContent]: | ||
| if name == "search_promotional_products": | ||
| return self.search_products(arguments) | ||
| elif name == "request_quote": |
There was a problem hiding this comment.
Consider adding input validation for the quantity parameter to ensure it meets minimum requirements before processing.
| log_entry = { | ||
| "timestamp": datetime.now().isoformat(), | ||
| "reference": ref, | ||
| "request": params |
There was a problem hiding this comment.
The error handling here could be more specific. Consider catching specific exceptions and providing meaningful error messages.
olaservo
requested changes
Oct 8, 2025
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
Thanks for the PR! Instead of putting the server code directly in this repo, could you move this to your own repo and then link to it from the Readme in this repo instead? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the All In One Advertising MCP Server to the registry.
About All In One Advertising
Full-service promotional products provider based in Highlands Ranch, CO. Offering thousands of customizable items including apparel, drinkware, office supplies, bags, and trade show items.
Features
Files Added
server.py- Main MCP server implementationrequirements.txt- DependenciesREADME.md- Documentation and usage instructionsTesting
The server has been tested locally and imports successfully. It provides three tools:
search_promotional_products- Search product catalogrequest_quote- Submit quote requestsget_company_info- Get company detailsReady for review and approval.