fix(sequential-thinking): use z.coerce for number and boolean params#3533
Open
nielskaspers wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
LLM clients (Claude Code, Augment.AI, etc.) intermittently send thoughtNumber, totalThoughts, and nextThoughtNeeded as strings instead of native JSON types. Using z.coerce gracefully handles both string and native inputs without breaking existing behavior. Fixes modelcontextprotocol#3428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLM clients intermittently send
thoughtNumber,totalThoughts, and boolean fields as strings instead of native JSON types, causing Zod validation errors. This replaces strictz.number()andz.boolean()withz.coerce.number()andz.coerce.boolean()in the inputSchema to gracefully accept both formats.Issue
Fixes #3428
Changes
z.number()withz.coerce.number()forthoughtNumber,totalThoughts,revisesThought, andbranchFromThoughtz.boolean()withz.coerce.boolean()fornextThoughtNeeded,isRevision, andneedsMoreThoughtsTesting
z.coerce.number()accepts both1and"1", coercing strings to numbersz.coerce.boolean()accepts bothtrueand"true", coercing strings to booleans.int().min(1)and.optional()constraints are preserved