Skip to content

Migrate to vitest from jest#1074

Merged
pcarleton merged 12 commits intomodelcontextprotocol:mainfrom
mattzcarey:migrate-to-vitest
Nov 14, 2025
Merged

Migrate to vitest from jest#1074
pcarleton merged 12 commits intomodelcontextprotocol:mainfrom
mattzcarey:migrate-to-vitest

Conversation

@mattzcarey
Copy link
Contributor

@mattzcarey mattzcarey commented Nov 3, 2025 •
edited
Loading

its newer, faster, works natively with the modern toolchain like typescript.

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@mattzcarey mattzcarey requested review from a team as code owners November 3, 2025 21:51
@mattzcarey
Copy link
Contributor Author

mattzcarey commented Nov 4, 2025

The main motivation to do this is that vitest works with ESM modules natively. This means we can use MSW to test MCP servers more effectively. MSW is a lovely tool and is pretty much standard practise when testing typescript servers.

@KKonstantinov
Copy link
Contributor

KKonstantinov commented Nov 10, 2025 •
edited
Loading

Fully support this. Was discussed in #1015 and #916 but not progressed. Additionally other repos are already migrating (e.g. modelcontextprotocol/servers#2884). It only makes sense that we do it here too!

@felixweinberger
Copy link
Contributor

felixweinberger commented Nov 11, 2025

Support shipping this as this seems like a pareto improvement. Looks like there are some conflicts to resolve.

Looking at CI:

CleanShot 2025-11-11 at 19 26 00

Not sure if these 2 are stalling because of this PR

@mattzcarey mattzcarey closed this Nov 12, 2025
@mattzcarey mattzcarey reopened this Nov 13, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 13, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@1074

commit: 6dba08f

felixweinberger
felixweinberger approved these changes Nov 13, 2025
View reviewed changes
pcarleton
pcarleton requested changes Nov 13, 2025
View reviewed changes
Copy link
Member

@pcarleton pcarleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, ty for doing this. just had 2 questions about parts i didn't understand

mattzcarey and others added 3 commits November 13, 2025 15:26
@mattzcarey
pls vite plsss
e36d141
@felixweinberger
Merge branch 'main' into migrate-to-vitest
b83e039
@felixweinberger
Fix incomplete vitest migration in auth.test.ts
6dba08f 
Replace remaining Jest-specific APIs with Vitest equivalents:
- jest.Mock -> Mock (already imported from vitest)
- jest.fn() -> vi.fn()
- Add non-null assertion for TypeScript strict null check
@felixweinberger
Copy link
Contributor

felixweinberger commented Nov 14, 2025

@mattzcarey pushed a fix for the failing CI
@pcarleton ready for a stamp

@pcarleton pcarleton merged commit 98df118 into modelcontextprotocol:main Nov 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KKonstantinov KKonstantinov KKonstantinov left review comments

@pcarleton pcarleton pcarleton approved these changes

@felixweinberger felixweinberger felixweinberger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattzcarey @KKonstantinov @felixweinberger @pcarleton