Add theme property to Icon schema #1290
Open
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
themeproperty toIconSchemato bring the TypeScript SDK into full compliance with the MCP specification (2025-11-25).Motivation and Context
The MCP specification defines an optional
themeproperty on theIconinterface to indicate whether an icon is designed for light or dark backgrounds. While the SDK'sspec.types.ts(auto-generated from the MCP spec) correctly includestheme?: "light" | "dark"on theIconinterface, theIconSchemaintypes.tsused for Zod validation was missing this property.How Has This Been Tested?
No type errors from running
npm run typecheckBreaking Changes
None. This is a non-breaking additive change:
themeproperty is optional, so existing code continues to workthemespecified will pass validation as beforetheme: "light"ortheme: "dark"in their icon definitionsTypes of changes
Checklist
Additional context