Skip to content

v1.x #1623 follow up -add missing types to package.json#1773

Open
KKonstantinov wants to merge 1 commit intov1.xfrom
pr-1623-follow-up
Open

v1.x #1623 follow up -add missing types to package.json#1773
KKonstantinov wants to merge 1 commit intov1.xfrom
pr-1623-follow-up

Conversation

@KKonstantinov
Copy link
Contributor

Follow up to #1623

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@KKonstantinov KKonstantinov requested a review from a team as a code owner March 26, 2026 21:28
@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2026

⚠️ No Changeset found

Latest commit: 9cfb020

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 26, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@modelcontextprotocol/sdk@1773

commit: 9cfb020

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward addition of missing types fields to package.json exports, following the established pattern.

Extended reasoning...

Overview

This PR adds missing types fields to 5 export entries in package.json: ./validation, ./validation/ajv, ./validation/cfworker, ./experimental, and ./experimental/tasks. This is a follow-up to PR #1623 which added typings exports but missed these entries.

Security risks

None. This is a package.json metadata change only — no code, no dependencies, no auth or crypto changes.

Level of scrutiny

Minimal scrutiny needed. The change is purely mechanical: each added types field follows the exact same ./dist/esm/<path>.d.ts convention already established by the existing ., ./client, and ./server entries. The types field is correctly placed first in each conditional export object, which is the recommended order for TypeScript resolution.

Other factors

No outstanding reviewer comments. No bugs found. The changeset bot flagged no changeset, which is appropriate for a metadata-only fix. The pattern is consistent and correct across all entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant