Skip to content

Improve synchronous section#3807

Merged
HansOlsson merged 22 commits intomodelica:masterfrom
HansOlsson:ImproveSync
Jan 29, 2026
Merged

Improve synchronous section#3807
HansOlsson merged 22 commits intomodelica:masterfrom
HansOlsson:ImproveSync

Conversation

@HansOlsson
Copy link
Copy Markdown
Collaborator

Adds example, and moves one section that was out of place.
Closes #3783

@HansOlsson HansOlsson added the clocked Clocked parts of Modelica; synchronous and state-machines label Jan 13, 2026
Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex
Comment thread chapters/synchronous.tex
Comment thread chapters/synchronous.tex
HansOlsson and others added 3 commits January 15, 2026 14:31
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
And description of example for event-clocks.
I didn't use the simpler "Event clocks cannot be super-sampled:"
@HansOlsson
Copy link
Copy Markdown
Collaborator Author

I believe I have now handle all of the comments.
Note the slightly wordier "Showing restrictions on super-sampling event clocks" instead of "Event clocks cannot be super-sampled", since (as the example shows) you can superSample something based on an event clock as long as it is effectively subSampling the signal.

Basically, people can interpret super-sampling to either mean using superSample operator, or super-sampling the original signal.

I'm not 100% happy with the text - but I think the example itself is so clear that people that it doesn't matter; and the text at least gives the context for the example, and the normative text describes it.

Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
HansOlsson and others added 2 commits January 15, 2026 16:11
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
HansOlsson and others added 2 commits January 15, 2026 16:29
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Comment thread chapters/synchronous.tex
Comment thread chapters/synchronous.tex
Comment thread chapters/synchronous.tex
Comment thread chapters/synchronous.tex Outdated
HansOlsson and others added 2 commits January 23, 2026 10:19
Copy link
Copy Markdown
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what's up with Github today, so I make a general comment here instead of attaching to a line where it belongs.

Wouldn't throwing in time like this (only for the first time mentioned in the sequence, for brevity) make it even better?

Here \lstinline!y! has the value 0 at time 0.0, 1 at 1.0, etc, \lstinline!ySub! has the value 0 at time 0.0, 4 at 4.0, 8 at 8.0 etc.

Comment thread chapters/synchronous.tex Outdated
Copy link
Copy Markdown
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this less important remark above, I think the only important thing remaining is a sentence to be moved into one of the examples, but I'm not familiar with the presentation of changes on Github today, so I could have missed something…

Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
Comment thread chapters/synchronous.tex Outdated
Copy link
Copy Markdown
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is at least one place where the word time needs to be inserted. Apart from that I think it is time to merge and move on.

HansOlsson and others added 2 commits January 28, 2026 09:20
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Copy link
Copy Markdown
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to move on!

@HansOlsson HansOlsson merged commit 4a68636 into modelica:master Jan 29, 2026
1 check passed
@HansOlsson HansOlsson deleted the ImproveSync branch January 29, 2026 09:15
@HansOlsson HansOlsson added M37 For pull requests merged into Modelica 3.7 example Issue regarding example in specification labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clocked Clocked parts of Modelica; synchronous and state-machines example Issue regarding example in specification M37 For pull requests merged into Modelica 3.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add at least one example of Sub-Clock Conversion Operators applied to clocked expressions

2 participants