feat: add bmp extension support to default_video_operator#1466
Open
daqiege wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Adds 'bmp' to the supported image extensions in UnifiedDataset.default_video_operator so that BMP files can be loaded by the same LoadImage + ImageCropAndResize path as JPG/PNG/WebP. Fixes modelscope#1456
daqiege
force-pushed
the
fix/bmp-support-video-operator
branch
from
91c3668 to
7cca9bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bmpto the supported image extensions inUnifiedDataset.default_video_operatorso that BMP image datasets can be used for training/processing alongside JPG/PNG/WebP.Motivation
Issue #1456 reports that BMP files are not accepted by the dataset loader even though
LoadImage(PIL-backed) handles them natively. The fix is to include"bmp"in the extension tuple routed to theLoadImage >> ImageCropAndResize >> ToListpipeline — identical behavior to the other still-image formats.Closes #1456
Test plan
Image.openalready supports.bmp, soLoadImagedoes not need any change