Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience of the Web UI showcase pages by ensuring better video loading and presentation. It introduces a poster image for the embedded video to provide a visual cue before playback and adds a direct link to the video on GitHub as a robust fallback mechanism, improving accessibility and reliability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the showcase pages for the Web UI in both English and Chinese. It adds a poster image to the demo video and a fallback link in case the video doesn't load. My review identifies a potential issue with how the video and poster image assets are being sourced. They appear to be hotlinked from a temporary location or referenced via a relative path that might not work if the asset is not included in the repository. To ensure the showcase page displays correctly and reliably, these assets should be added to the repository and referenced with stable paths.
|
|
||
| <div align="center"> | ||
| <video controls autoplay muted loop playsinline width="100%" src="https://github.com/user-attachments/assets/704dbc0a-3df6-436a-b7f7-fb1edefbfb8c"></video> | ||
| <video controls autoplay muted loop playsinline width="100%" poster="Sirchmunk_Home.png" src="https://github.com/user-attachments/assets/704dbc0a-3df6-436a-b7f7-fb1edefbfb8c"></video> |
There was a problem hiding this comment.
Using github.com/user-attachments for the video source is unreliable as these links are not permanent and can lead to broken content. Similarly, for the poster image to work, Sirchmunk_Home.png must be added to the repository and be available at the correct path when the site is built. It is strongly recommended to store both the video and the image as static assets within this repository and update the src and poster attributes to use stable paths relative to the site root.
|
|
||
| <div align="center"> | ||
| <video controls autoplay muted loop playsinline width="100%" src="https://github.com/user-attachments/assets/704dbc0a-3df6-436a-b7f7-fb1edefbfb8c"></video> | ||
| <video controls autoplay muted loop playsinline width="100%" poster="Sirchmunk_Home.png" src="https://github.com/user-attachments/assets/704dbc0a-3df6-436a-b7f7-fb1edefbfb8c"></video> |
There was a problem hiding this comment.
Using github.com/user-attachments for the video source is unreliable as these links are not permanent and can lead to broken content. Similarly, for the poster image to work, Sirchmunk_Home.png must be added to the repository and be available at the correct path when the site is built. It is strongly recommended to store both the video and the image as static assets within this repository and update the src and poster attributes to use stable paths relative to the site root.
No description provided.