Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
apps/reactwith one Astro host and one Astro remote using Reactdev:react/ build scripts and a small port cleanup helper@astrojs/react,react, andreact-domexplicitly@module-federation/astroSSR local remote resolution to include.tsxand.jsx@module-federation/viteto^1.13.6Why
The repo only had the Astro-to-Astro example. We needed a concrete React remote example that matches the current package contract: no renderer API in
@module-federation/astro, host config owns the React renderer setup.The SSR local remote resolver also skipped
.tsx/.jsx, which broke the React remote SSR path whenssr.localRemoteswas configured.Impact
apps/reactssr.localRemotesfor React component sourcesValidation
pnpm --filter @module-federation/astro testpnpm --filter react-remote buildpnpm --filter react-host buildpnpm dev:reactcurl -I http://localhost:4331/curl -I http://localhost:4332/mf-manifest.json