fix(vuetools): add VueTools\Service for MODX service container#6
Open
Ibochkarev wants to merge 1 commit intomasterfrom
Open
fix(vuetools): add VueTools\Service for MODX service container#6Ibochkarev wants to merge 1 commit intomasterfrom
Ibochkarev wants to merge 1 commit intomasterfrom
Conversation
MODX 3 resolves service 'vuetools' by loading VueTools\Service from
model/vuetools/. Add Service.php extending VueCore so getService('vuetools')
succeeds and xPDO no longer logs 'Could not load class'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODX 3 resolves the
vuetoolsservice by loading classVueTools\Servicefrommodel/vuetools/. The component only hadVueCoreinsrc/and registered the service via a closure in bootstrap, so xPDO attempted the conventional class load first and failed with "Could not load class: VueTools\Service from vuetools\service".Add
core/components/vuetools/model/vuetools/Service.phpthat extendsVueCoreand explicitly requiresVueCore.phpso the class is loadable regardless of bootstrap/autoload order.$modx->services->get('vuetools')then resolves to the same behaviour (Import Map, styles, etc.) without errors.No build changes: the package already ships the full
core/components/vuetools/tree, so the newmodel/directory is included automatically.