Merged
Conversation
HadronCollider
requested changes
Dec 7, 2025
Comment on lines
+13
to
+16
| class TablePercentage(BaseReportCriterion): | ||
| label = "Проверка процентного соотношения таблиц в документе" | ||
| description = "Проверяет, что таблицы занимают не более установленного процента площади документа" | ||
| id = 'table_percentage' |
Collaborator
There was a problem hiding this comment.
Придерживайтесь шаблонов именования
- классы -
Pres<_>Check - id =
pres_<>_check
Collaborator
There was a problem hiding this comment.
Отформатируйте код по pep8
vovanbravin
force-pushed
the
544_table_percentage
branch
from
d3d35ed to
98fce79
Compare
Collaborator
Author
|
@HadronCollider Здравствуйте, я проверил на dev, у меня критерий запускается и работает. Может вы его не заметили, у меня он шел 15. |
HadronCollider
requested changes
Feb 15, 2026
Collaborator
HadronCollider
left a comment
HadronCollider
left a comment
There was a problem hiding this comment.
Нет проверки на большие таблицы (занимающие больше N страниц)
HadronCollider
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#544