fix: fall back to location.origin when VITE_KOMODO_HOST is empty string#1426
Open
ahmd-soliman wants to merge 1 commit into
Open
fix: fall back to location.origin when VITE_KOMODO_HOST is empty string#1426ahmd-soliman wants to merge 1 commit into
ahmd-soliman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1359.
ui/DockerfiledefaultsARG VITE_KOMODO_HOST="", so any image built without overriding the ARG bakes the empty string into the bundle.??only falls back onnull/undefined, soKOMODO_BASE_URLends up as"". That breaksnew WebSocket("/ws/update")(absolute URL required) and makes auth/API requests resolve against the page origin instead of the configured backend.Switching to
||covers the empty-string case while preserving the existing behavior for unset and real-URL values.Reproduced locally with
VITE_KOMODO_HOST="" yarn dev:Also verified with the env var unset — output is unchanged either way, so the dev path isn't affected.