fix(monad): exclude blob suites from MONAD_EIGHT#15
fix(monad): exclude blob suites from MONAD_EIGHT#15haythemsellami wants to merge 1 commit intomonad-developers:forks/monad_ninefrom
Conversation
Greptile SummaryThis PR introduces a Key changes:
Coverage concern — KZG precompile tests incorrectly excluded: Confidence Score: 2/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pytest collects test] --> B{has valid_for_blob_forks marker?}
B -- No --> C[ValidForBlobForks returns empty set\nforks - empty = unchanged fork set]
B -- Yes --> D[ValidForBlobForks._process_with_marker_args\nbuilds set of blobless forks]
D --> E[fork.supports_blobs == False?]
E -- Yes --> F[Add fork + its transition forks to exclusion set]
E -- No --> G[Skip fork]
F --> H[process: forks - exclusion set]
G --> H
C --> I[Test runs for all selected forks]
H --> I
subgraph MONAD_EIGHT overrides
J[supports_blobs → False]
K[header_excess_blob_gas_required → False]
L[header_blob_gas_used_required → False]
M[tx_types → Prague types minus type-3]
N[blob_schedule → None]
O[engine_get_blobs_version → None]
P[engine_new_payload_blob_hashes → False]
Q[full_blob_tx_wrapper_version → None]
end
D -->|checks| J
Last reviewed commit: 6c37550 |
tests/cancun/eip4844_blobs/test_point_evaluation_precompile_gas.py
Outdated
Show resolved
Hide resolved
pdobacz
left a comment
There was a problem hiding this comment.
Nice, thank you so much for this!
Can you switch the target to the default forks/monad_nine. I believe some of the diff should disappear.
Also, does this setup now allow to fill cancun/eip4844... tests with some meaningful result? if so, we may want to un-exclude them in the .github/configs/feature.yaml fill commands.
6c37550 to
31f6b47
Compare
@pdobacz I addressed all the issues/bot's comments. For cancun/eip4844..., I don’t think we should un-exclude the whole group in .github/configs/feature.yaml yet. The actual blob-tx/blob-header suites are still not meaningful for Monad because MONAD_EIGHT/MONAD_NINE do not support blobs. The point-evaluation precompile suites are meaningful now, but they currently fail on both MONAD_EIGHT and MONAD_NINE with real behavior mismatches, so I’d keep the broad exclusion for now and narrow it only after we fix those KZG failures. |
Summary
Verification