Skip to content

Add Crypto-Volk validator (ID 235)#860

Merged
johnmarcou merged 1 commit intomonad-developers:mainfrom
crypto-volk:main
Mar 10, 2026
Merged

Add Crypto-Volk validator (ID 235)#860
johnmarcou merged 1 commit intomonad-developers:mainfrom
crypto-volk:main

Conversation

@crypto-volk
Copy link
Contributor

No description provided.

@crypto-volk crypto-volk requested a review from a team as a code owner March 10, 2026 14:06
@greptile-apps
Copy link

greptile-apps bot commented Mar 10, 2026

Greptile Summary

This PR adds a new validator entry for Crypto-Volk (ID 235) by creating a single JSON file in the testnet/ directory. The file follows the repository's established format and passes all structural checks.

Key observations:

  • The filename (03063a588a9b68021c4204eab0fa2d33df9cdf583df6dd537e80d35e1fe16dccc7.json) correctly matches the secp field value.
  • All required fields are present: id, name, secp, bls, website, description, logo, and x.
  • The secp key is 66 hex characters (correct for a compressed secp256k1 public key).
  • The bls key is 96 hex characters (correct for a BLS12-381 G1 compressed public key, matching the example file format).
  • ID 235 is unique — no other file in the repository uses this ID.
  • The logo URL references a raw GitHub asset, consistent with other validators in the repository.
  • The website field points to a Telegram channel rather than a traditional website. This is not incorrect (the field accepts any URL), but other validators typically use a dedicated web presence here.

Confidence Score: 5/5

  • This PR is safe to merge — it adds a single, well-formed validator JSON entry with no structural or logical issues.
  • The file follows the required format exactly, all cryptographic key lengths are correct, the filename matches the secp key, ID 235 is unique in the repository, and all mandatory fields are populated with valid URLs and values.
  • No files require special attention.

Important Files Changed

Filename Overview
testnet/03063a588a9b68021c4204eab0fa2d33df9cdf583df6dd537e80d35e1fe16dccc7.json New validator entry for Crypto-Volk (ID 235) — filename matches the secp key, all required fields present, key lengths are valid, no duplicate ID detected.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Submitted: Add Crypto-Volk Validator] --> B{Filename matches secp key?}
    B -- Yes --> C{All required fields present?}
    B -- No --> FAIL1[❌ Reject: Filename mismatch]
    C -- Yes --> D{secp key length = 66 hex chars?}
    C -- No --> FAIL2[❌ Reject: Missing fields]
    D -- Yes --> E{bls key length = 96 hex chars?}
    D -- No --> FAIL3[❌ Reject: Invalid secp key]
    E -- Yes --> F{ID unique across testnet/?}
    E -- No --> FAIL4[❌ Reject: Invalid bls key]
    F -- Yes --> G[✅ Valid Validator Entry]
    F -- No --> FAIL5[❌ Reject: Duplicate ID]
Loading

Last reviewed commit: 8585bea

@johnmarcou johnmarcou merged commit 855a878 into monad-developers:main Mar 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants