Open
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Greptile SummaryThis PR adds a validator info JSON file for Nomadz (ID: 236) to the testnet directory, following the repository's standard format for validator registration.
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: New validator JSON file] --> B{JSON parseable?}
B -- No --> FAIL1[❌ Fail: Invalid JSON]
B -- Yes --> C{Schema fields match\nexample template?}
C -- No --> FAIL2[❌ Fail: Schema mismatch]
C -- Yes --> D{name field\nnon-empty?}
D -- No --> FAIL3[❌ Fail: Empty name]
D -- Yes --> E{logo URL reachable\nand returns image?}
E -- No --> FAIL4[❌ Fail: Bad logo URL]
E -- Yes --> F{On-chain SECP & BLS\nmatch file values?}
F -- No --> FAIL5[❌ Fail: Key mismatch]
F -- Yes --> G{Filename equals\nsecp_key.json?}
G -- No --> FAIL6[❌ Fail: Filename mismatch]
G -- Yes --> PASS[✅ Validation successful]
Last reviewed commit: b0bd2a5 |
| "description": "Web3-native travel aggregator.", | ||
| "logo": "https://dbe7z6l3hnxemv33crsbun4rdq4wklp6hjtanjwbmmy3gpmbc2fa.ardrive.net/GEn8-Xs7bkZXexRkGjeRHDllLf46ZgamwWMxsz2BFoo", | ||
| "x": "https://x.com/nomadzxyz" | ||
| } No newline at end of file |
There was a problem hiding this comment.
Missing newline at end of file
All other JSON files in this repository end with a trailing newline (\n), but this file does not (the diff shows \ No newline at end of file). While the CI validation script (validate.py) parses the file with json.loads() which tolerates this, the omission breaks consistency with the rest of the repo's files.
Suggested change
| } | |
| } |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validator info for Nomadz (ID: 236)