Skip to content

Add Nomadz validator info#862

Open
pyaremenko wants to merge 1 commit intomonad-developers:mainfrom
pyaremenko:add-nomadz-validator
Open

Add Nomadz validator info#862
pyaremenko wants to merge 1 commit intomonad-developers:mainfrom
pyaremenko:add-nomadz-validator

Conversation

@pyaremenko
Copy link

Adds validator info for Nomadz (ID: 236)

Co-Authored-By: Oz <oz-agent@warp.dev>
@pyaremenko pyaremenko requested a review from a team as a code owner March 13, 2026 12:36
@greptile-apps
Copy link

greptile-apps bot commented Mar 13, 2026

Greptile Summary

This PR adds a validator info JSON file for Nomadz (ID: 236) to the testnet directory, following the repository's standard format for validator registration.

  • All required fields are present (id, name, secp, bls, website, description, logo, x) and match the expected types from the example schema
  • The filename correctly matches the secp public key field value
  • Validator ID 236 and both the SECP and BLS keys are unique across the entire repository (no duplicates in either testnet/ or mainnet/)
  • The BLS key is 96 hex characters (48 bytes), consistent with all other entries in the repo
  • The logo URL points to an ArDrive/Arweave gateway — CI's check_logo() will validate that the URL is reachable and returns an image/* content type
  • Minor style issue: the file is missing a trailing newline (\ No newline at end of file), unlike every other JSON file in the repository

Confidence Score: 4/5

  • Safe to merge after CI passes; only a minor missing-newline style issue was found.
  • The change is a single, well-formed JSON data file. All required fields are present and correctly typed, the filename matches the secp key, and no duplicate IDs or keys were found. The only finding is a missing trailing newline, which does not affect correctness or CI validation. The on-chain key match (secp/bls vs. chain) will be verified automatically by the CI workflow.
  • No files require special attention beyond CI passing the on-chain key verification.

Important Files Changed

Filename Overview
testnet/036156920306163816eb579ccc2c24d5190438c94b261398aa660f8d9306ca0335.json New validator info file for Nomadz (ID 236); all required fields are present, filename matches the secp key, and both the ID and key pair are unique in the repo. Minor: file is missing a trailing newline unlike all other files in this repository.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: New validator JSON file] --> B{JSON parseable?}
    B -- No --> FAIL1[❌ Fail: Invalid JSON]
    B -- Yes --> C{Schema fields match\nexample template?}
    C -- No --> FAIL2[❌ Fail: Schema mismatch]
    C -- Yes --> D{name field\nnon-empty?}
    D -- No --> FAIL3[❌ Fail: Empty name]
    D -- Yes --> E{logo URL reachable\nand returns image?}
    E -- No --> FAIL4[❌ Fail: Bad logo URL]
    E -- Yes --> F{On-chain SECP & BLS\nmatch file values?}
    F -- No --> FAIL5[❌ Fail: Key mismatch]
    F -- Yes --> G{Filename equals\nsecp_key.json?}
    G -- No --> FAIL6[❌ Fail: Filename mismatch]
    G -- Yes --> PASS[✅ Validation successful]
Loading

Last reviewed commit: b0bd2a5

"description": "Web3-native travel aggregator.",
"logo": "https://dbe7z6l3hnxemv33crsbun4rdq4wklp6hjtanjwbmmy3gpmbc2fa.ardrive.net/GEn8-Xs7bkZXexRkGjeRHDllLf46ZgamwWMxsz2BFoo",
"x": "https://x.com/nomadzxyz"
} No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at end of file

All other JSON files in this repository end with a trailing newline (\n), but this file does not (the diff shows \ No newline at end of file). While the CI validation script (validate.py) parses the file with json.loads() which tolerates this, the omission breaks consistency with the rest of the repo's files.

Suggested change
}
}

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant