Skip to content

PYTHON-5662 - Add support for server selection's deprioritized servers to all topologies #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NoahStapp wants to merge 7 commits into
base: master
Choose a base branch
from
Open

PYTHON-5662 - Add support for server selection's deprioritized servers to all topologies #2639

NoahStapp wants to merge 7 commits into from
+1,801 −72

Conversation

@NoahStapp
Copy link
Contributor

@NoahStapp NoahStapp commented Dec 8, 2025 •
edited by caseyclements
Loading

Changes in this PR

Align PyMongo's server selection process with the updated algorithm in DRIVERS-3344. The summary of these changes are:

  • Enable server deprioritization on all topologies instead of only sharded.
  • Filter out deprioritized servers before applying read/write preferences.

Test Plan

Expanded the existing server selection unit tests to include deprioritization tests.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@NoahStapp NoahStapp requested a review from a team as a code owner December 8, 2025 19:40
@NoahStapp NoahStapp mentioned this pull request Dec 8, 2025
Open
4 tasks
blink1073
blink1073 previously approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming nothing changes in the spec PR

caseyclements
caseyclements previously approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM conditional on currently running resync patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caseyclements caseyclements caseyclements left review comments

@blink1073 blink1073 blink1073 left review comments

@sleepyStick sleepyStick Awaiting requested review from sleepyStick

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NoahStapp @caseyclements @blink1073