Skip to content

fix(input): correct caps lock indicator state (@VardanRattan) #7477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VardanRattan wants to merge 3 commits into
base: master
Choose a base branch
from
+20 −9
Open

fix(input): correct caps lock indicator state (@VardanRattan) #7477

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92f303b
fix(input): derive caps lock state from keyboard events
VardanRattan Feb 6, 2026
0b72863
fix(caps-warning): defer CapsLock modifier read on Linux
VardanRattan Feb 7, 2026
897dbd5
fix(caps-warning): handle CapsLock keydown on Linux
VardanRattan Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions frontend/src/ts/test/caps-warning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,11 @@ function hide(): void {
}
}

function update(event: KeyboardEvent): void {
if (event.key === "CapsLock" && capsState !== null) {
capsState = !capsState;
} else {
const modState = event.getModifierState?.("CapsLock");
if (modState !== undefined) {
capsState = modState;
}
function updateFromEvent(event: KeyboardEvent): void {
const modState = event.getModifierState?.("CapsLock");

if (modState !== undefined) {
capsState = modState;
}

try {
Expand All @@ -41,8 +38,22 @@ function update(event: KeyboardEvent): void {
} catch {}
}

function update(event: KeyboardEvent): void {
// Linux: CapsLock modifier state may not be updated synchronously
// when the CapsLock key event fires, so defer the read.
if (Misc.isLinux() && event.key === "CapsLock") {
setTimeout(() => updateFromEvent(event), 0);
} else {
updateFromEvent(event);
}
}

document.addEventListener("keyup", update);

document.addEventListener("keydown", (event) => {
if (Misc.isMac()) update(event);
if (Misc.isMac()) {
update(event);
} else if (Misc.isLinux() && event.key === "CapsLock") {
update(event);
}
});