fix(test-activity): prevent tooltip overflow on small viewports (@Mubashir21)#7821
Open
Mubashir21 wants to merge 1 commit intomonkeytypegame:masterfrom
Open
fix(test-activity): prevent tooltip overflow on small viewports (@Mubashir21)#7821Mubashir21 wants to merge 1 commit intomonkeytypegame:masterfrom
Mubashir21 wants to merge 1 commit intomonkeytypegame:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug: On small/mobile viewports, the activity calendar tooltips near the left and right edges get clipped by the viewport boundary because the tooltip position was hardcoded to "up" for every cell.
Fix: After the cells are rendered, I measure the actual tooltip width using a hidden probe element with the same font styles as the balloon tooltip. For each cell, I use getBoundingClientRect() to check if the tooltip would overflow the left or right edge of the viewport. If it would, the position is switched to "up-left" or "up-right" accordingly. A ResizeObserver on the container recalculates positions on every resize, so it works correctly at any viewport width.
Steps to reproduce: Go to /account, shrink the browser window to mobile width, hover over cells on the left or right edge of the activity calendar: the tooltip gets cut off.
Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.ts