Upgrade websockets API (#91)#93
Conversation
This error can happen when crow.serial = None, indicating crow is not connected. It might happen in other cases too, but this seems common and mundane enough to mention to the user.
|
thank you for investigating this! confirmed that it's now working. the errors are frustrating, i suspect this could be addressed with configuration options or another exception handler. maybe websocat isn't closing the connection the way it wants? i'll see if i can poke at it and make it a clean fix |
|
Yeah I might take another poke at it if I have some more time. I'd like to do some kind of wiresharking to inspect the difference between what causes the errors and what doesn't. Might just be that the library got pickier. |
|
regrettably I haven't had the bandwidth to delve into this (it's really beyond my expertise) so a potential workaround is to use a python project manager that pegs a specific version. had to do this to salvage not sure if this will simply be how managing old python projects goes from now on |
2 participants
This upgrades druid's consumption of the websockets API and better handles websocket messages while crow is disconnected.
NB: some errors are still logged when talking to druid with
websocatvialocalhostbut not via127.0.0.1(as described in #91). However, these don't block functionality and also aren't present when using python's websockets, so they are a different issue, possibly nothing to do with druid.