Added an additional way to enter a password & "-o" option now writes the output to a file.#4
Open
svandenhoek wants to merge 9 commits intomoonso:masterfrom
Open
Added an additional way to enter a password & "-o" option now writes the output to a file.#4svandenhoek wants to merge 9 commits intomoonso:masterfrom
svandenhoek wants to merge 9 commits intomoonso:masterfrom
Conversation
…etpass (so that the password is not stored in the command-line history).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the app I noticed that the output was not written to a file while using "-o", so I took the liberty to make some adjustments (hope you don't mind). These include:
.gitignore.getpass()so that a password prompt appears when not using-p(this way a password will not be stored in the terminal history).-ooption (not sure how click handles file flushing/closing, though added a finally clause to do this just to be sure). The output file has a file header as well.