Dump hs#3
Draft
ChangseokSong wants to merge 23 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a feature to dump auxiliary hidden states and last hidden states produced during EAGLE speculative decoding.
The main purpose is to support SpecForge offline training, and it can also be used to collect data from real requests for training draft models.
Modifications
Hidden-state capture
Dumping workflow
HiddenStateDumper, which manages preparing payloads, staging tensors on CPU, and writing them to disk.Buffer reuse
FlatBufferPool, which reuses CPU buffers to reduce allocation overhead.Accuracy Tests
Benchmarking and Profiling
Checklist