drop CinderJob.decision property#24864
Open
eviljeff wants to merge 1 commit intomozilla:masterfrom
Open
Conversation
eviljeff
force-pushed
the
16173-drop-cinderjob-decision
branch
from
75cd6bf to
9a71cdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16173
Description
Just refactoring, no functional changes.
Context
The only places we ever needed to know the first decision were in tests, checking correct model states.
Testing
n/a,
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.