Bug 2038991 - Update Cache when calling register_previous_gecko_pref_states#7369
Open
ohall-m wants to merge 1 commit into
Open
Bug 2038991 - Update Cache when calling register_previous_gecko_pref_states#7369ohall-m wants to merge 1 commit into
ohall-m wants to merge 1 commit into
Conversation
…states Bug 2021137 removed end_initialize and set `writer.commit()` to prevent a loop. However, this change had a side-effect of a stale cache. This patch fixes it by: * Adding a param of `update_gecko_prefs` to `commit_and_update` * Having `register_previous_gecko_pref_states` call `commit_and_update` with `update_gecko_prefs=false` * Updating `map_gecko_prefs_to_enrollment_slugs_and_update_store` to take a param of `update_gecko_prefs`, when false, it will not set information with Gecko
ohall-m
commented
May 13, 2026
Contributor
Author
ohall-m
left a comment
ohall-m
left a comment
There was a problem hiding this comment.
Manually tested by going through setting each of the Nimbus-QA prefs using CLIs, ran a few unenrollment scenarios (pref changing, opt-out), and the dual Enrollment/Rollout test.
| } | ||
|
|
||
| writer.commit()?; | ||
| let coenrolling_ids = self |
Contributor
Author
There was a problem hiding this comment.
Copied this from end_initialize.
I interpreted that commit_and_update was handling the writer.commit()?;.
Diverged a little bit from what we talked about since commit_and_update seemed like it could be used directly, LMKWYT!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2021137 removed end_initialize and set
writer.commit()to prevent a loop. However, this change had a side-effect of a stale cache.This patch fixes it by:
update_gecko_prefstocommit_and_updateregister_previous_gecko_pref_statescallcommit_and_updatewithupdate_gecko_prefs=falsemap_gecko_prefs_to_enrollment_slugs_and_update_storeto take a param ofupdate_gecko_prefs, when false, it will not set information with GeckoPull Request checklist
[ci full]to the PR title.