Bug-2003889: Return an appropriate message when lando is still loading#1039
Open
moijes12 wants to merge 2 commits into
Open
Bug-2003889: Return an appropriate message when lando is still loading#1039moijes12 wants to merge 2 commits into
moijes12 wants to merge 2 commits into
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
=======================================
Coverage 96.38% 96.39%
=======================================
Files 113 113
Lines 3267 3272 +5
Branches 736 736
=======================================
+ Hits 3149 3154 +5
Misses 117 117
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Updated the response message in src/logic/treeherder.ts to convey to the user that lando has still not completed the try pushes. - Added the required unit tests
Fixing snapshots after running `npm ci && npm run fix-all`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Introduced
Updated the response message in
src/logic/treeherder.tsto convey to the user that lando has still not completed the try pushes.Testing
The App.test.tsx has been updated with a test for the new change
@kala-moz @gmierz