Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion browser-tests/plugins/test_slack.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def test_slack_plugin(
{
"event": "kinto_remote_settings.signer.events.ReviewRequested",
"channel": "#reviews",
"template": "{user_id} requested review for {changes_count} changes ({comment}) on {bucket_id}/{collection_id}.",
"template": "{user_id} requested review for {changes_count} changes ({comment}) on {bucket_id}/{collection_id} on {settings[project_name]}.",
}
]
}
Expand Down Expand Up @@ -51,4 +51,5 @@ def test_slack_plugin(
assert payload["channel"] == "#reviews"
assert "integration-tests" in payload["text"]
assert "looks good" in payload["text"]
assert "Remote Settings LOCAL" in payload["text"] # see config/local.ini
assert re.search(r"\d+ changes", payload["text"])
5 changes: 5 additions & 0 deletions kinto-slack/src/kinto_slack/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ def build_notification(event):
event=qualname(event),
**event.payload,
)
context["settings"] = {
k: v
for k, v in event.request.registry.settings.items()
if k in ("project_name", "url", "project_version")
}
context.setdefault("record_id", "{record_id}")
context.setdefault("collection_id", "{collection_id}")

Expand Down
Loading