Show bug suggestions once per test in the Failure Summary.#9172
Open
fqueze wants to merge 1 commit intomozilla:masterfrom
Open
Show bug suggestions once per test in the Failure Summary.#9172fqueze wants to merge 1 commit intomozilla:masterfrom
fqueze wants to merge 1 commit intomozilla:masterfrom
Conversation
fqueze
commented
Jan 22, 2026
|
|
||
| const suggestions = []; | ||
|
|
||
| // Open recent bugs |
Contributor
Author
There was a problem hiding this comment.
github's diff viewer doesn't make it as clear as phabricator would, but this is just adding the if (suggestion.showBugSuggestions) { test and increasing the indent level of the block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug suggestions lists are currently shown once per failure line in the Failure Summary. That takes a lot of vertical space and makes it harder to see the list of failure messages.
Before:
With the patch applied:
