Bug 2021696 - Use a fixed chunk size in the Perfherder data cycler#9533
Open
junngo wants to merge 1 commit into
Open
Bug 2021696 - Use a fixed chunk size in the Perfherder data cycler#9533junngo wants to merge 1 commit into
junngo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary adaptive chunk size logic in Perfherder data cycler. The
_find_ideal_chunk_size()methods inMainRemovalStrategyandIrrelevantDataRemovalwere calculating a chunk size based on ID ranges, but this was redundant. The SQL already filters rows bypush_timestampandLIMIThandles partial results correctly.Replaced with a fixed chunk size passed directly to the query.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=2021696