Skip to content

Bug 2039553 - Alerts View: some alert outer lines disappear when having a note attached #9539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmiculit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug 2039553 - Alerts View: some alert outer lines disappear when having a note attached #9539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/perfherder/alerts/AlertTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ export default class AlertTable extends React.Component {
<tr
className={`${
alertSummary.notes
? 'border-top border-left border-right'
? 'border-top border-start border-end'
: 'border'
}`}
>
Expand Down
2 changes: 1 addition & 1 deletion ui/perfherder/alerts/AlertTableRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ export default class AlertTableRow extends React.Component {
return (
<tr
className={`align-middle ${
alertSummary.notes ? 'border-top border-left border-right' : 'border'
alertSummary.notes ? 'border-top border-start border-end' : 'border'
}`}
aria-label="Alert table row"
data-testid={alert.id}
Expand Down
2 changes: 1 addition & 1 deletion ui/perfherder/alerts/CollapsableRows.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default class CollapsableRows extends React.Component {
<AlertTableRow key={alert.id} alert={alert} {...this.props} />
))}
<tr
className="border-left border-right"
className="border-start border-end"
role="button"
onClick={() => this.toggleRows()}
data-testid={isOpen ? 'show-less-alerts' : 'show-more-alerts'}
Expand Down