Skip to content

osc: only clear thumbnails when hiding #17954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
N-R-K wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

osc: only clear thumbnails when hiding #17954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fde6186
osc: only clear thumbnails when hiding
N-R-K May 21, 2026
35e5545
osc: fix thumbnails clearing on visibility change
N-R-K May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions player/lua/osc.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2708,7 +2708,9 @@ end

local function osc_visible(visible)
set_bar_visible("osc_visible", visible)
disable_thumbnail()
if not visible then
Copy link
Copy Markdown
Member

@kasper93 kasper93 May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if thumbnail should be shown when visible=true, why ignore?

Copy link
Copy Markdown
Contributor Author

@N-R-K N-R-K May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if thumbnail should be shown when visible=true, why ignore?

This should be handled by the ui drawing code already.

But more importantly, I noticed that going into visibility never doesn't even clear the thumbnail, even on master.

Copy link
Copy Markdown
Contributor Author

@N-R-K N-R-K May 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled by the ui drawing code already.

Yeah this doesn't work either. You need to actively move your mouse to retrigger the thumbnail.

Copy link
Copy Markdown
Contributor Author

@N-R-K N-R-K May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But more importantly, I noticed that going into visibility never doesn't even clear the thumbnail, even on master.

Should be fixed now.

Copy link
Copy Markdown
Contributor Author

@N-R-K N-R-K May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled by the ui drawing code already.

Yeah this doesn't work either. You need to actively move your mouse to retrigger the thumbnail.

If you go from visibility never -> auto, then the osc itself doesn't redraw either without moving the mouse manually. This seems like a deeper issue with how osc drawing works.

Copy link
Copy Markdown
Contributor Author

@N-R-K N-R-K May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you go from visibility never -> auto, then the osc itself doesn't redraw either without moving the mouse manually.

#17969

disable_thumbnail()
end
end

local function set_wc_visible(visible)
Expand Down Expand Up @@ -2748,9 +2750,9 @@ end
local function hide_bar(label, visible_key, anitype_key, set_visible)
msg.trace("hide_" .. label)
if not state.enabled then
set_visible(false)
-- typically hide happens at render() from tick(), but now tick() is
-- no-op and won't render again to remove the osc, so do that manually.
state[visible_key] = false
render_wipe(state.osd)
elseif user_opts.fadeduration > 0 then
if state[visible_key] then
Expand Down
Loading