Skip to content

complete control byte stripping#17957

Open
curious-rabbit wants to merge 1 commit into
mpv-player:masterfrom
curious-rabbit:fix
Open

complete control byte stripping#17957
curious-rabbit wants to merge 1 commit into
mpv-player:masterfrom
curious-rabbit:fix

Conversation

@curious-rabbit
Copy link
Copy Markdown

The current sanitizer let BS, VT, FF and raw 8-bit C1 bytes (0x80-0x9F) reach the terminal, which a hostile filename or title can use to overwrite or clear output. Allow only HT, LF, CR among C0 and block raw C1, with aUTF-8-aware skip so emoji and other multi-byte characters still pass.

this means on vte terminals (gnome terminal,) xterm and some other terminal emulators the filter can be circumvented and control bytes are interpreted.

Comment thread common/msg.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants