various fixes#18016
Open
na-na-hi wants to merge 9 commits into
Open
Conversation
ractx and vk are parented to ctx. No need to free manually.
And only free explicitly on success. On failure it will be freed by parent. Fixes: [Bug] vf_gpu_vulkan: Use-after-free of ctx_opts
No need to call SDL_GameControllerGetJoystick if controller is NULL.
Fixes: [Bug] subprocess-posix: Signal mask leak when fork fails in detach path
Fixes: [Bug] vf_amf.c: Profile always forced to FRC_PROFILE_HIGH
Not effect for current handlers. Fixes: [Bug] frame.c: Wrong handler check in mp_frame_set_pts (get_pts instead of set_pts)
N-R-K
reviewed
May 24, 2026
| } | ||
| pthread_sigmask(SIG_SETMASK, &oldmask, NULL); | ||
| if (fres < 0) | ||
| goto done; |
Contributor
There was a problem hiding this comment.
#14973 should fix this also. That PR seems like it's ready for merge except a small comment, so I think it's better to merge that instead of creating conflicts.
Contributor
Author
There was a problem hiding this comment.
That PR seems like it's ready for merge except a small comment
I don't think so. The posix_spawn question remains unanswered regarding practical interaction responsiveness (as opposed to the "dispatch" test which doesn't map to responsiveness) and platform support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes various "major" and "critical" bugs.