Skip to content

sub/sd_ass: subtitle timing rounding error #18039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasper93 merged 1 commit into from
May 31, 2026
+4 −4
Merged

sub/sd_ass: subtitle timing rounding error #18039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sub/sd_ass.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@ static void filter_and_add(struct sd *sd, struct demux_packet *pkt)
}

ass_process_chunk(ctx->ass_track, pkt->buffer, pkt->len,
llrint(pkt->pts * 1000),
llrint(pkt->duration * 1000));
floor(pkt->pts * 1000 + 1e-6),
floor(pkt->duration * 1000 + 1e-6));
Comment thread
kasper93 marked this conversation as resolved.

// This bookkeeping only has any practical use for ASS subs
// over a VO with no video.
Expand Down Expand Up @@ -663,7 +663,7 @@ static long long find_timestamp(struct sd *sd, double pts)
if (pts == MP_NOPTS_VALUE)
return 0;

long long ts = llrint(pts * 1000);
long long ts = floor(pts * 1000 + 1e-6);

if (!sd->opts->sub_fix_timing ||
sd->shared_opts->ass_style_override[sd->order] == ASS_STYLE_OVERRIDE_NONE)
Expand Down Expand Up @@ -1023,7 +1023,7 @@ static int control(struct sd *sd, enum sd_ctrl cmd, void *arg)
switch (cmd) {
case SD_CTRL_SUB_STEP: {
double *a = arg;
long long ts = llrint(a[0] * 1000.0);
long long ts = floor(a[0] * 1000.0 + 1e-6);
long long res = ass_step_sub(ctx->ass_track, ts, a[1]);
if (!res)
return false;
Expand Down
Loading