Use 'npm run build' and 'npm run start' to build and run.#7
Open
madrang wants to merge 8 commits intomrchimp:masterfrom
Open
Use 'npm run build' and 'npm run start' to build and run.#7madrang wants to merge 8 commits intomrchimp:masterfrom
madrang wants to merge 8 commits intomrchimp:masterfrom
Conversation
… net::ERR_FILE_NOT_FOUND by adding jquery as a submodule, uses development version to simplify debugging.
…tart" to start a webserver and test the example.
Changed from "git://" to "https://" as recommanded on GitHub. Fixespage build failed with the following error: The submodule registered for `./dependencies/jquery` could not be cloned. Make sure it's using https:// and that it's a public repo. For more information, see https://help.github.com/articles/page-build-failed-invalid-submodule. For information on troubleshooting Jekyll see: https://help.github.com/articles/troubleshooting-jekyll-builds
Owner
|
Why include jquery and typer as submodules instead of npm dependencies? |
Author
|
Easier to contribute to those project if someone want to and you can just drop the needed files in the right folder and it's still going to work. (Git by default is not recursive when cloning, the --recursive flag needs to be used so that it will fetch submodules) Also i wasn't sure about how to copy those dependencies using npm, where they would go and if i could get the uncompressed/unminimised version of jquery as it makes it harder to debug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used npm to define a build and start option that can be run using
Updated grunt to copy needed dependencies.