chore: Add todo comment#3864
Draft
mrousavy wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useCameraDevice(..)anduseCameraDevices()needs to change a bit.If no
filter?arg is passed, we should useCameraDeviceFactory.getDefaultCamera(..)instead - this is the OS recommended Camera. If an argument is passed, we should filter based on all available Camera Devices.However, the CameraDeviceFactory is created asynchronously and should be shared across hooks calls and ideally also imperative API calls in the other file. Also, there's
addOnCameraDevicesChangedListener(..), which potentially also affects the result ofCameraDeviceFactory.getDefaultCamera(..)- at least we should treat it as if it would affect that even though it likely only affects external Cameras in practice.Still, in this case the hook may recompute that Camera if that changed. I guess we should compare it via
id? Otherwise it'd be a new object + full Camera Session reconfigure each re-compute.Anyways, the default case should be the
CameraDeviceFactory.getDefaultCamera(..)- without compromising advanced cases for filtering. We should also add depth to filter options so users can find depth capable cameras more quickly