fix: initialize iOS preview orientation#3899
Open
Phecda wants to merge 1 commit into
Open
Conversation
|
@Phecda is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an iOS preview orientation race when the camera is first configured after launching the app directly into landscape.
HybridInterfaceOrientationManagerpreviously initializedcurrentOrientationasynchronously on the main queue. In fast startup paths,HybridCameraPreviewOutput.configure(...)could run before that async orientation read completed, leaving the preview connection without the current interface orientation until a later orientation notification arrived.This PR makes the initial orientation available earlier and applies it more reliably:
configure(...)runs beforecurrentOrientationis available.Reproduction branch:
https://github.com/Phecda/react-native-vision-camera/tree/repro/ios-landscape-preview-orientation
Repro Steps:
Expected: the preview is landscape.
Actual: the first preview is rotated by 90 degrees; re-entering the camera screen fixes it.
Changelog
[IOS] [FIXED] - Initialize and apply preview interface orientation during first camera configuration.
Test Plan
Result:
I also reproduced the issue with the example app by launching directly in landscape and verified this fix in a downstream app where release builds previously showed the first preview rotated by 90 degrees until leaving and re-entering the camera screen.