Skip to content

fix(ios): weight resolution pixel-distance so targetResolution isn't overridden by FPS #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richkuo wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(ios): weight resolution pixel-distance so targetResolution isn't overridden by FPS #3964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-native-vision-camera/ios/Extensions/CoreMedia/CMVideoDimensions+penalty.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,13 @@ extension CMVideoDimensions {

let targetPixels = Double(target.width) * Double(target.height)
let actualPixels = Double(width) * Double(height)
let logPixelDistance = Swift.abs(log(actualPixels / targetPixels))
// Weight pixel-distance on the same scale as the aspect term so the
// requested resolution stays a first-class signal. The raw log-ratio
// (~0–1.4) is otherwise far weaker than the FPS penalty (raw frame units,
// up to 30), so requesting a high FPS silently escalates the recording
// resolution well past `targetResolution` (e.g. a front-camera 1080p@60
// request lands on 4K@60 even though a native 1080p@60 format exists).
let logPixelDistance = aspectMismatchWeight * Swift.abs(log(actualPixels / targetPixels))

return aspectRatioPenalty + logPixelDistance
}
Expand Down