Skip to content

Area7 gem structure w mtodd testdbs#14

Open
bbozo wants to merge 17 commits intomtodd:masterfrom
bbozo:area7_gem_structure_w_mtodd_testdbs
Open

Area7 gem structure w mtodd testdbs#14
bbozo wants to merge 17 commits intomtodd:masterfrom
bbozo:area7_gem_structure_w_mtodd_testdbs

Conversation

@bbozo
Copy link

@bbozo bbozo commented May 6, 2013

Most failing tests were due to outdated IP resolutions, see https://gist.github.com/bbozo/5523578

Remaining fails are:

  1) Failure:
test_blank_region_skips_region_name_set(GeoIPCityTest) [/home/bbozo/dev/geoip/test/test_geoip.rb:142]:
<nil> expected but was
<"00">.

  2) Failure:
test_character_encoding_converted_to_utf8_first(GeoIPCityTest) [/home/bbozo/dev/geoip/test/test_geoip.rb:136]:
<"São Paulo"> expected but was
<"S\xC3\xA3o Paulo">.

luislavena and others added 17 commits January 16, 2013 16:17
@luislavena
Ensure file is loaded with correct encoding
70866e3
@luislavena
Stripe spaces
6fe3755
@luislavena
Introduce a Gemfile to manage development dependencies
6ddc717 
Lot has been deprecated in Rake so we need to install things like
RDoc.

Also prepare the ground for usage of rake-compiler.
@luislavena
Ignore bundler generated files
f73a614
@luislavena
Relocate extension files into ext/geoip folder
48dc69f 
Move things out of root of the gem to avoid things like:

  require "extconf"

Messing things up

Once extension is compiled it will be moved by RubyGems to lib
directory, so there is no need to indicate "." be added to the
$LOAD_PATH
@luislavena
Use RDoc task for documentation
ea19eb0 
This resolves the deprecation warning caused by usage of old rake.
@luislavena
Adjust ignored directories to exclude RDoc artifacts
1606a56
@luislavena
DRY gemspec usage
989960c 
Instead of duplicated gemspec to maintain, load the spec from the
file.
@luislavena
Use RubyGems package task instead of Rake one
df65cf9 
This solve deprecation warnings and also ensure gems get properly
packaged.
@luislavena
Compile extension using rake-compiler
08557db 
This opens the door for cleaner compilation and later add cross
compilation support.
@luislavena
Set test encoding header and remove full path require
3339260 
Without it, Ruby 1.9.x can't read the test file.

Rake::TestTask automatically adds 'lib' directory to $LOAD_PATH.
@luislavena
Download GeoLiteCity database and use it on tests
ca6de81 
Clobber the data files from 'data' when requested.

Also ignore data directory from Git.
@luislavena
Default task is to run tests
e81d71b 
Since test already depends on compile
@luislavena
Relocate test file to default 'test' directory
3e11a48 
And rename it to match the module it is testing.
@luislavena
Avoid segfault caused by missing region_name
4a49381 
For some country+region combos, region_name might not be found, which
results in a NULL string and causes segfault when strlen() is performed
on it.
@bbozo
Merged gem structure pull from area17 with testdbs from mtodd
0b384ae
@bbozo
Tests pass for New York now (24.24.24.24), its East Syracuse really
fcd8c23
@bbozo
Copy link
Author

bbozo commented May 6, 2013

The first failed test is also legit, we need another IP with no region set, this one has a region now. The other failed test isn't even submitted among issues here,

actually... there's no issues button here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bbozo @luislavena