Skip to content

[toggle] Fix grouped cancelation and JSDoc#4940

Open
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/toggle-cancellation-handling
Open

[toggle] Fix grouped cancelation and JSDoc#4940
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/toggle-cancellation-handling

Conversation

@atomiks
Copy link
Copy Markdown
Contributor

@atomiks atomiks commented May 29, 2026

This is part of the Codex review sweep

Changes

  • Stop grouped Toggle handling immediately when onPressedChange cancels the event.
  • Add regression coverage for canceled Toggle and ToggleGroup changes, including the parent callback staying quiet when child cancellation vetoes the change.
  • Document data-disabled for Toggle and add accessible labels to the ToggleGroup hero demos.

@atomiks atomiks added accessibility a11y component: toggle Changes related to the toggle component. component: toggle group Changes related to the toggle group component. docs Improvements or additions to the documentation. type: bug It doesn't behave as expected. labels May 29, 2026 — with ChatGPT Codex Connector
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

commit: 56db58e

@code-infra-dashboard
Copy link
Copy Markdown

code-infra-dashboard Bot commented May 29, 2026

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 🔺+17B(0.00%) 🔺+2B(0.00%)

Details of bundle changes

Performance

Total duration: 1,363.88 ms +134.14 ms(+10.9%) | Renders: 50 (+0) | Paint: 2,050.08 ms +166.74 ms(+8.9%)

Test Duration Renders
Slider mount (300 instances) 225.55 ms 🔺+73.55 ms(+48.4%) 3 (+0)
Checkbox mount (500 instances) 115.74 ms 🔺+55.84 ms(+93.2%) 1 (+0)
Tooltip mount (300 contained roots) 64.64 ms 🔺+12.03 ms(+22.9%) 1 (+0)

9 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 29, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 56db58e
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a194b12c7bb080008cc604d
😎 Deploy Preview https://deploy-preview-4940--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks changed the title [toggle] Fix grouped cancellation handling [toggle] Fix grouped cancelation and JSDoc May 29, 2026
@atomiks atomiks marked this pull request as ready for review May 29, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility a11y component: toggle group Changes related to the toggle group component. component: toggle Changes related to the toggle component. docs Improvements or additions to the documentation. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant