Skip to content

[navigation menu] Fix interaction, value, and styling-hook bugs#4942

Draft
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/navigation-menu-sweep
Draft

[navigation menu] Fix interaction, value, and styling-hook bugs#4942
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/navigation-menu-sweep

Conversation

@atomiks
Copy link
Copy Markdown
Contributor

@atomiks atomiks commented May 29, 2026

This is part of the Codex sweep for Navigation Menu. It restores the local fixes from the recovered branch while preserving newer upstream changes.

Changes

  • Prevented disabled triggers from opening through hover, click, or keyboard paths.
  • Avoided duplicate onValueChange calls when switching items via keyboard.
  • Treated non-nullish falsy item values as valid open values.
  • Exposed the documented actionsRef.unmount() action.
  • Pinned left-side popup transitions to the correct edge.
  • Documented the missing Navigation Menu styling hooks.

Original findings addressed

  • Disabled triggers could still activate their content.
  • Keyboard activation could emit duplicate value changes.
  • Falsy item values were handled like closed values in root cleanup.
  • The documented imperative unmount action was not wired up.
  • Popup and data-attribute styling hooks were incomplete.

@atomiks atomiks added component: navigation menu Changes related to the navigation menu component. type: bug It doesn't behave as expected. labels May 29, 2026 — with ChatGPT Codex Connector
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

commit: ffefc22

@code-infra-dashboard
Copy link
Copy Markdown

code-infra-dashboard Bot commented May 29, 2026

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 🔺+45B(+0.01%) 🔺+30B(+0.02%)

Details of bundle changes

Performance

Total duration: 1,128.39 ms -208.34 ms(-15.6%) | Renders: 50 (+0) | Paint: 1,701.15 ms -332.41 ms(-16.3%)

Test Duration Renders
Slider mount (300 instances) 155.07 ms ▼-65.51 ms(-29.7%) 3 (+0)
Scroll Area mount (300 instances) 78.94 ms ▼-20.10 ms(-20.3%) 3 (+0)

10 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 29, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit ffefc22
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a1970c858a7aa0008bcd923
😎 Deploy Preview https://deploy-preview-4942--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: navigation menu Changes related to the navigation menu component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant