Update UnixTime struct to support U64::Max timestamps #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanshubo
changed the title
lanshubo
force-pushed
the
feat/fix-time-limit
branch
from
4a66ff5 to
1711579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the UnixTime struct can only support timestamps up to i64::MAX due to its reliance on SystemTime for time comparison. If a cert's
valid_beforeis set to all-1s (indicating the certificate has no end expiry date), decofing cert will fail.With this update, when converting from SystemTime, any timestamp greater than i64::MAX will be clamped to i64::MAX. Meanwhile, the internal u64 field in UnixTime continues to store the accurate timestamp value.
This approach is acceptable and does not affect the original logic, since SystemTime is used solely for time comparison purposes.