This repository was archived by the owner on Mar 14, 2019. It is now read-only.
Fix up includes to nlohmann json #29
Closed
z3ntu wants to merge 3 commits intomujx:masterfrom
z3ntu:nlohmann_json
Closed
Fix up includes to nlohmann json #29z3ntu wants to merge 3 commits intomujx:masterfrom z3ntu:nlohmann_json
z3ntu wants to merge 3 commits intomujx:masterfrom
z3ntu:nlohmann_json
Conversation
As written in the README of that project, see https://github.com/nlohmann/json/#integration
Author
|
And here the build fails because the docker image doesn't get built during process and therefore doesn't contain the necessary change. The Windows and Mac ( |
mujx
reviewed
Sep 25, 2018
Owner
mujx
left a comment
mujx
left a comment
There was a problem hiding this comment.
Btw there already an open PR for the same issue.
| ce6b5610a051ec6795fa11c33854abebb086f0fd67c311f5921c3c07f9531b44) | ||
|
|
||
| file(DOWNLOAD ${JSON_HEADER_URL} ${DEPS_INSTALL_DIR}/include/json.hpp | ||
| file(DOWNLOAD ${JSON_HEADER_URL} ${DEPS_INSTALL_DIR}/include/nlohmann/json.hpp |
Owner
There was a problem hiding this comment.
It would be better to use the install target of the this project so we can also use find_package.
Author
|
Oh, didn't see the other PR. #28 looks better so I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might require more changes for the changed include path
See also mujx/nheko#448