Merged
Conversation
domvo
force-pushed
the
add-prettier-and-eslint-to-project
branch
from
86a74b0 to
2e1ccbc
Compare
Contributor
Author
|
since I'm gonna start the work on i18n now, I'll go ahead and merge the PR. @Simmarith we can always change the rules later, if you happen to have strong objections |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added prettier and eslint to the project along with the needed plugins and config tweaks to make that work.
Most changes in this PR are no-op changes and just concern the formatting.
I also added a github action to run these checks in pull requests. Should become visible here in the PR, too, if everything worked as expected.