Revert "Closes #258. Remove use_transport flag"#267
Revert "Closes #258. Remove use_transport flag"#267BBArrosDias wants to merge 1 commit intomasterfrom
use_transport flag"#267Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 71.65% 71.65%
=======================================
Files 135 135
Lines 9089 9089
=======================================
Hits 6513 6513
Misses 2576 2576 ☔ View full report in Codecov by Sentry. |
|
No, but this same issue also affects #265; see this comment. My guess is that it is this line; it probably needs a tolerance on this check. I actually had to do this myself when compiling M++ with old Intel 2018 compilers. I changed it to: with Again, I don't have a Mac, so I can't test my hypothesis. I would suggest making this change and re-running pipeline before reverting the merge. There is nothing wrong with the merge itself, as it doesn't affect the M-W code at all. I can make a PR with this change if you'd like, that will trigger a pipeline, and if it passes, then we're good. |
Reverts #259
The Build / build_mac tests have failed.
@mgoodson-cvd do you have a Mac?